Evaluate creating "tamper" sensors for each sensor

XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel

MIT License

134 stars 13 forks source link

Evaluate creating "tamper" sensors for each sensor #98

Open XaF opened 1 year ago

XaF commented 1 year ago

Pros:

Clear sensor identifying if another sensor is currently tampered
Possible to disable by default a sensor, but keep its tamper enabled by default (e.g. for sensors that do not update a state, but do support tamper)

Cons:

A lot more sensors showing in Home Assistant, more noisy
Huge internal refactor as a single QolsysSensor object might lead to more than one sensor sent to MQTT
Breaking change (we could probably keep, but deprecate, the tamper attribute for a few versions)

jsb5151 commented 1 year ago

IMHO, I don't think this is feasible due to #117 - multiple loop sensors will most likely always create phantom Tampered conditions when another sensor is triggered on the same device.