search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
3.98k stars 771 forks source link

Ensure all HealthChecks libraries have a .NETCoreApp TFM. #2185

Closed eerhardt closed 3 months ago

eerhardt commented 3 months ago

This ensures that when libraries and apps who depend on the HealthChecks libraries get the correct transitive dependences for .NETCoreApp TFMs (for example Microsoft.Bcl.AsyncInterfaces).

This follows the following guidance:

✔️ CONSIDER multi-targeting even if your source code is the same for all targets, when your project has any library or package dependencies.

Fix #2180 Fix #2084 Fix #2163

cc @damianedwards

unaizorrilla commented 3 months ago

LGTM

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.73%. Comparing base (e8702a2) to head (e038a89).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2185 +/- ## ========================================== + Coverage 64.11% 66.73% +2.62% ========================================== Files 248 154 -94 Lines 8359 3547 -4812 Branches 586 374 -212 ========================================== - Hits 5359 2367 -2992 + Misses 2852 1101 -1751 + Partials 148 79 -69 ``` | [Flag](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ApplicationStatus](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `28.67% <ø> (+2.00%)` | :arrow_up: | | [ArangoDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `28.30% <ø> (+1.79%)` | :arrow_up: | | [Aws.S3](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.52% <ø> (+1.24%)` | :arrow_up: | | [Aws.SecretsManager](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.82% <ø> (+1.27%)` | :arrow_up: | | [Aws.Sns](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.97% <ø> (+1.20%)` | :arrow_up: | | [Aws.Sqs](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.66% <ø> (+1.38%)` | :arrow_up: | | [Aws.SystemsManager](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.82% <ø> (+1.27%)` | :arrow_up: | | [Azure.IoTHub](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.82% <ø> (+1.00%)` | :arrow_up: | | [AzureApplicationInsights](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.56% <ø> (+1.85%)` | :arrow_up: | | [AzureBlobStorage](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `26.42% <ø> (?)` | | | [AzureDigitalTwin](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `37.15% <ø> (+1.38%)` | :arrow_up: | | [AzureEventHubs](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `17.46% <ø> (?)` | | | [AzureFileStorage](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `26.42% <ø> (?)` | | | [AzureKeyVault](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `30.48% <ø> (+1.23%)` | :arrow_up: | | [AzureQueueStorage](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `26.42% <ø> (?)` | | | [AzureSearch](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `17.60% <ø> (+1.49%)` | :arrow_up: | | [AzureServiceBus](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.48% <ø> (+1.13%)` | :arrow_up: | | [AzureTableStorage](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `27.97% <ø> (?)` | | | [Consul](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `24.32% <ø> (+1.74%)` | :arrow_up: | | [CosmosDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `29.45% <ø> (+1.34%)` | :arrow_up: | | [DocumentDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.00% <ø> (+1.35%)` | :arrow_up: | | [DynamoDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.29% <ø> (+1.16%)` | :arrow_up: | | [Elasticsearch](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `41.12% <ø> (+1.62%)` | :arrow_up: | | [EventStore](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [EventStore.gRPC](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [Gcp.CloudFirestore](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.33% <ø> (+1.23%)` | :arrow_up: | | [Gremlin](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `25.00% <ø> (+1.92%)` | :arrow_up: | | [Hangfire](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `12.10% <ø> (+1.12%)` | :arrow_up: | | [IbmMQ](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `30.76% <ø> (ø)` | | | [InfluxDB](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.54% <ø> (+0.54%)` | :arrow_up: | | [Kafka](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `23.52% <ø> (+1.49%)` | :arrow_up: | | [Kubernetes](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [MongoDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `32.85% <ø> (+1.07%)` | :arrow_up: | | [MySql](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `33.33% <ø> (+1.70%)` | :arrow_up: | | [Nats](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.77% <ø> (+2.91%)` | :arrow_up: | | [Npgsql](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [OpenIdConnectServer](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `41.26% <ø> (+1.98%)` | :arrow_up: | | [Oracle](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `63.92% <ø> (+3.31%)` | :arrow_up: | | [Prometheus.Metrics](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [Publisher.ApplicationInsights](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.27% <ø> (+0.50%)` | :arrow_up: | | [Publisher.CloudWatch](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `20.33% <ø> (+1.31%)` | :arrow_up: | | [Publisher.Datadog](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.33% <ø> (+1.33%)` | :arrow_up: | | [Publisher.Prometheus](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [Publisher.Seq](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [RabbitMQ](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `49.56% <ø> (+1.88%)` | :arrow_up: | | [RavenDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `73.42% <ø> (+2.68%)` | :arrow_up: | | [Redis](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `68.47% <ø> (+2.75%)` | :arrow_up: | | [SendGrid](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.19% <ø> (+1.27%)` | :arrow_up: | | [SignalR](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `25.97% <ø> (+1.75%)` | :arrow_up: | | [SqlServer](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `30.43% <ø> (+1.86%)` | :arrow_up: | | [Sqlite](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `28.20% <100.00%> (+1.82%)` | :arrow_up: | | [System](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `43.58% <ø> (+1.02%)` | :arrow_up: | | [UI](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [Uris](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.