search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.05k stars 793 forks source link

Use webpack5 syntax to include woff2 in bundle and remove url-loader #2217

Closed markmonster closed 2 months ago

markmonster commented 4 months ago

What this PR does / why we need it: This PR will fix the #2130 . The real developer of this PR is actually #2133 but this somehow got stuck in merging. That's why I tried to get the administrative process going after almost 5 months. The credits should go to schulz3000.

Which issue(s) this PR fixes: #2130

Special notes for your reviewer: Use webpack5 syntax to include woff2 in bundle and remove url-loader that's no longer in use.

Does this PR introduce a user-facing change?: It will reinstate the icons that got lost with a previous change.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

markmonster commented 4 months ago

@dotnet-policy-service agree

markmonster commented 4 months ago

@sungam3r do you know how I can ping the maintainer to look at this PR? Thanks.

Jamie-Clayton commented 3 months ago

I've tested this solution locally and it resolved a range of issues that have been floated around v8.x of the health check UIs.

HealthChecks-EndToEnd-PR2217

LGTM

Jamie-Clayton commented 3 months ago

@unaizorrilla - Would you have time to review some of these PR's, please? Gracias

Jamie-Clayton commented 3 months ago

@Alirexaa this would be a good inclusion in v8.1

benjaminoerskov commented 2 months ago

@markmonster Any idea when this can be released?

markmonster commented 2 months ago

@markmonster Any idea when this can be released?

I have no idea at all. This is managed by the maintainers of this project. I hope it can be released soon.

danmajgaard commented 4 weeks ago

This was released by 2024-08-29 with AspNetCore.HealthChecks.UI version 8.0.2

(not by me, im just a user of the package :) )