Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.12k stars 800 forks source link

Replace Nest to Elastic.Clients.Elasticsearch #2244

Closed Alirexaa closed 5 months ago

Alirexaa commented 5 months ago

What this PR does / why we need it:

using Elastic.Clients.Elasticsearch package instead of deprecated Nest package

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #2236

Special notes for your reviewer:

this PR brings the following breaking changes:

+public string? ApiKey { get; private set; }



**Does this PR introduce a user-facing change?**:
Yes.
Please make sure you've completed the relevant tasks for this PR, out of the following list:

- [X] Code compiles correctly
- [X] Created/updated tests
- [X] Unit tests passing
- [ ] End-to-end tests passing
- [ ] Extended the documentation
- [ ] Provided sample for the feature
Mpdreamz commented 5 months ago

Yes @adamsitnik this LGTM.

cc @flobernd who's the maintainer for the new .net client.

Alirexaa commented 5 months ago

The new UseElasticCloud method supports health check for elastic cloud. it should close: #2242

Alirexaa commented 5 months ago

@adamsitnik, we should block this PR until .NET 9 release, Right?

adamsitnik commented 5 months ago

we should block this PR until .NET 9 release, Right?

AFAIK the package won't be released to nuget.org until @unaizorrilla triggers some automation, so there is no need to wait with the merge.