search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.12k stars 800 forks source link

Add support for MongoDB.Driver version 3 #2324

Open eerhardt opened 6 days ago

eerhardt commented 6 days ago

MongoDB.Driver version 3 made a major breaking change by removing the MongoDB.Driver.Core assembly.

Handle this breaking change by splitting our package into 2, one for each major version.

  1. For the current HealthChecks.MongoDb package, we put a NuGet version limit on our dependency: [2.28.0,3.0.0). This way people won't be able to update to the 3.0.0 version, which will break their app.
  2. We add a new, forked component named HealthChecks.MongoDb.v3 which will have a dependency on 3.0.0 and contains updates so the health checks will work with v3. People who explicitly want to use version 3 can opt into using this package.
  3. When the next major version of HealthChecks ships, we can "swap" the dependencies around. The HealthChecks.MongoDb package will be updated to depend on version 3 of MongoDB.Driver. If MongoDB.Driver v2.x is still in support, we can create HeatlhChecks.MongoDb.v2 which has the dependency limit [2.28.0,3.0.0) and works with the version 2 of MongoDB.Driver. HealthChecks.MongoDb.v3 will be dead-ended.

Similar changes as Add support for RabbitMQ.Client version 7. (Xabaril/AspNetCore.Diagnostics.HealthChecks#2323).

Fix #2322

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 6 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.30%. Comparing base (4a49dfa) to head (d23edfd). Report is 23 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2324 +/- ## ========================================== + Coverage 64.25% 64.30% +0.04% ========================================== Files 248 253 +5 Lines 8399 8460 +61 Branches 590 598 +8 ========================================== + Hits 5397 5440 +43 - Misses 2853 2867 +14 - Partials 149 153 +4 ``` | [Flag](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [AzureApplicationInsights](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.56% <ø> (ø)` | | | [AzureDigitalTwin](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `37.15% <ø> (ø)` | | | [AzureEventHubs](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `17.46% <ø> (?)` | | | [AzureSearch](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `17.60% <ø> (ø)` | | | [AzureTableStorage](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `27.97% <ø> (?)` | | | [DocumentDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.00% <ø> (ø)` | | | [DynamoDb](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.29% <ø> (ø)` | | | [Elasticsearch](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `47.66% <ø> (+6.54%)` | :arrow_up: | | [Gcp.CloudFirestore](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `13.33% <ø> (ø)` | | | [Kubernetes](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `41.54% <ø> (ø)` | | | [SqlServer](https://app.codecov.io/gh/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `30.43% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.