search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.12k stars 800 forks source link

HealthChecks.DocumentDb #2325

Open adamsitnik opened 2 days ago

adamsitnik commented 2 days ago

HealthChecks.DocumentDb relies on deprecated Microsoft.Azure.DocumentDB.Core

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/0b1b657dac590cab673787cb3c8bd282388c4574/src/HealthChecks.DocumentDb/HealthChecks.DocumentDb.csproj#L12

From https://www.nuget.org/packages/Microsoft.Azure.DocumentDB.Core:

Please note, this package is obsolete as of 3/31/2023 and is no longer maintained or monitored. Microsoft encourages you to upgrade to the replacement package, Microsoft.Azure.Cosmos, to continue receiving updates.

We already provide a package that uses the recommended package:

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/tree/master/src/HealthChecks.CosmosDb

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/0b1b657dac590cab673787cb3c8bd282388c4574/src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj#L11

I believe that we should also deprecate HealthChecks.DocumentDb and remove the source code from the repo.

@eerhardt @unaizorrilla thoughts?