search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.04k stars 789 forks source link

Redis Sentinel support #611

Open sungam3r opened 4 years ago

sungam3r commented 4 years ago

Hi. I use RedisHealthCheck to connect to the Redis cluster in Sentinel mode so my connection string specifies Sentinel addresses, not Redis: tst-srv1.domain.com:26379,tst-srv2.domain.com:26379,tst-srv3.domain.com:26379 . I get this error:

RedisServerException: Error: ERR unknown command ECHO

MrFabio commented 1 year ago

Any news about this issue?

sungam3r commented 1 year ago

I ended up writing my own health check that works with sentinels.

MrFabio commented 1 year ago

Same, one that uses an IConnectionMultiplexer

sungam3r commented 1 year ago

When I posted this issue in 2020 I was not a collaborator in this project. Now I am, so actually I could bring new implementation for Sentinel here. Need to think about that. ping @SlavaUtesinov.

sungam3r commented 1 year ago

ping @SteppeHunter

sungam3r commented 1 year ago

There are not many new code, but it requires the preparation of the environment and tests to be confident in the right work. I'm not ready to spend time on it now. If someone helps with the preparation of CI (Sentinel environment), then it will be easier.