search

Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.07k stars 794 forks source link

Healthchecks for Hangfire #66

Closed pajzo closed 5 years ago

pajzo commented 5 years ago

I'm working on a Hangfire HealtCheck package.

Is there anything that i should be aware of before creating a PR? I'm new to open source contributions :)

See my work here: https://github.com/pajzo/AspNetCore.Diagnostics.HealthChecks/tree/add-hangfire

unaizorrilla commented 5 years ago

Hi @pajzo

Looks good, please send a PR and I try to start a conversation if any is not good, ok?

pajzo commented 5 years ago

@unaizorrilla deal - i just send the PR :)

67

unaizorrilla commented 5 years ago

Merged, at this moment the healthcheck is very limited to number of failed executions, can you improve the functionality with more scenarios??

Thanks!