search

Xabaril / AspNetCore.Hashids

Not predictable ids library for ASP.NET Core APIs.
Apache License 2.0
113 stars 15 forks source link

Bypassing the hashing. #8

Closed Abdulrhman5 closed 2 years ago

Abdulrhman5 commented 3 years ago

https://github.com/Xabaril/AspNetCore.Hashids/blob/5360e4646c3cbd7fda8822b6a572ccfbaabd4205/src/AspNetCore.Hashids/Json/HashidsJsonConverter.cs#L27

if you supply the id as an integer this converter will accept it instead of throwing an error.

unaizorrilla commented 3 years ago

Hi @Abdulrhman5

It' is true... @lurumad are you able to do that?

unaizorrilla commented 3 years ago

Hi @Abdulrhman5

PR is on the way!

https://github.com/Xabaril/AspNetCore.Hashids/pull/9

unaizorrilla commented 3 years ago

Hi @Abdulrhman5

A new preview https://www.nuget.org/packages/AspNetCore.Hashids/1.2.0-preview10 is on NuGet. Can you check it and let me know if all is working as expected?

Remember use the new opt-in to configure if clean ids are allowed or not

Abdulrhman5 commented 2 years ago

Perfect, Thank you so much :)