search

Xabaril / Esquio

Esquio is a Feature Toggle Library for .NET Developers.
Apache License 2.0
428 stars 49 forks source link

Kronos11 feature/other db stores #141

Closed Kronos11 closed 4 years ago

Kronos11 commented 4 years ago

Continuing from #139

unaizorrilla commented 4 years ago

Hi @Kronos11

I try to review the builds, but, are you seeing my changes? I'm planing to merge this for Esquio 4 branch ( this week )

Kronos11 commented 4 years ago

Hi @Kronos11

I try to review the builds, but, are you seeing my changes? I'm planing to merge this for Esquio 4 branch ( this week )

I'll review this today and try out the sample

unaizorrilla commented 4 years ago

OK, I'm releasing 3.1 ( minor changes, fix issue #131 on UI and update runtime, sdk) after this, master will be 4.0.0 :-)

Kronos11 commented 4 years ago

Verified it's all looking good, if you accept my PR to this branch it should fix the github issues

unaizorrilla commented 4 years ago

Can I close this? Because is merged on Kronos11-feature/otherDbStores ??

Kronos11 commented 4 years ago

Can I close this? Because is merged on Kronos11-feature/otherDbStores ??

This is to merge into master for the 4.0 release right? I'm not sure what your branching strategy is.

unaizorrilla commented 4 years ago

Hi @Kronos11

this commits are merged on Xabaril:Kronos11-feature/otherDbStores with #143 !!

Kronos11 commented 4 years ago

Correct, sorry I may not be understanding, but we can close this if you plan on doing a merge later with the Kronos11-feature/otherDbStores branch

unaizorrilla commented 4 years ago

Yeap after some more testing, I think PlotStatisticsRequestHandler is now working ok on Npgsql, this branch will be merged and your commits honored in the history :-)