search

Xabaril / Esquio

Esquio is a Feature Toggle Library for .NET Developers.
Apache License 2.0
428 stars 49 forks source link

Bug/repro 157 #159

Closed Kronos11 closed 4 years ago

Kronos11 commented 4 years ago

Reproduces exception in #157

Kronos11 commented 4 years ago

Fixes bug by adding in a null check before adding anything to httpContextAccessor, Ideally if ScopedEvaluation is disabled we would use the NoScopedEvaluationHolder instead of the HttpScopedEvaluationHolder

unaizorrilla commented 4 years ago

Hi @Kronos11

This PR also include the change of multiple subjects config, (this pr is pending to merge).. can you split on different PR's the fix for 157 and the multiple subject scenario?

Kronos11 commented 4 years ago

Yup, sorry about that

Kronos11 commented 4 years ago

closing