search

Xabaril / Esquio

Esquio is a Feature Toggle Library for .NET Developers.
Apache License 2.0
429 stars 49 forks source link

Feature/issues 163 #164

Closed Kronos11 closed 1 year ago

Kronos11 commented 4 years ago

This adds in a default "To" value for the FromToToggle of DateTime.MaxValue

The idea is that the user wants the Toggle to be active from a point in time until it's disabled.

unaizorrilla commented 4 years ago

Hi @Kronos11

I'm on vacation! let me some days to check and review this PR

Kronos11 commented 4 years ago

Accidentally deleted this branch re-opening, no worries and enjoy your vacation

Kronos11 commented 4 years ago

@unaizorrilla Any thoughts on this? I understand if you would want to maybe just have a different Toggle for this, but it made sense if you don't put an end time on your toggle you would want it to go on until it was turned off.

unaizorrilla commented 4 years ago

Well, I can try to add new toggle for 4.X, this is not a breaking change and can be added easly

unaizorrilla commented 4 years ago

Hi @Kronos11

Looks good and make sense! , but after reviewing it I think we do this after adding a new feature about mandatory and optional parameters on toggles! ( ref #169 )

Let me do that first and I work on this when commited, I'm sorry for all the delay on this!