Xabaril / Esquio

Esquio is a Feature Toggle Library for .NET Developers.
Apache License 2.0
428 stars 49 forks source link

Error while registering custom toggles in different assembly #165

Closed CrahunGit closed 4 years ago

CrahunGit commented 4 years ago

Seems it tries to find the custom toggles from the current assembly where the ToggleTypeActivator is insetead of the registered assembly. The only solution I've found is replace the IToggleTypeActivator with my own implementation on the main project.

unaizorrilla commented 4 years ago

Hi @CrahunGit

I update samples (https://github.com/Xabaril/Esquio/blob/master/samples/GettingStarted.AspNetCore.Toggles) to include using custom toggles. But the idea is:

https://github.com/Xabaril/Esquio/blob/400a6399e1a5f1c534f42baaf7c8f68285c8e969/samples/GettingStarted.AspNetCore.Toggles/Startup.cs#L25

https://github.com/Xabaril/Esquio/blob/400a6399e1a5f1c534f42baaf7c8f68285c8e969/samples/GettingStarted.AspNetCore.Toggles/appsettings.json#L27

CrahunGit commented 4 years ago

You're right. Now it works as expected. I didn't take account about the fully qualified name