XachaB / Qumin

Quantitative modelling of inflection
https://qumin.readthedocs.io/
GNU General Public License v3.0
8 stars 1 forks source link

[PyPi] Deprecation warning #33

Open JPapir opened 2 months ago

JPapir commented 2 months ago

When installing Qumin with pypi, I get the following warning:

DEPRECATION: qumin is being installed using the legacy 'setup.py install' method, 
because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. 
pip 23.1 will enforce this behaviour change. A possible replacement is to enable 
the '--use-pep517' option. 
Discussion can be found at https://github.com/pypa/pip/issues/8559

If I understand it well, we should use a pyproject.toml file instead of setup.py ? Don't know it this is project related or only wrong setups on my side. Do not hesitate to close if irrelevant.

XachaB commented 2 months ago

Hi Jules, I think if you just install wheel, the warning will disappear.

But it is correct that it would be better for us to migrate from setup.cfg to pyproject.toml, so I'll keep the issue :)

JPapir commented 2 months ago

I think if you just install wheel, the warning will disappear.

That's what I thought at first, but then I added wheel in my requirements.txt so that it installs before Qumin, and still the same warning. I will try again once I will have a good internet connection.

XachaB commented 2 months ago

No, I think you need wheel first, in your environment, in order to install the Qumin with wheel (not as a dependency of Qumin). In the same way that you don't add "pip" as a requirement, I think.

I'm also with a low connection (currently in a bus, later in several trains), but having a look at your first MR :)

JPapir commented 2 months ago

All right, I will try that, thanks. Currently in a Flixbus also ;)

XachaB commented 2 months ago

You're right, I get this too.

I think we need to both migrate to pyproject.toml and for me to learn again how to distribute projects with this setup.