Xadras / stasiscl

Automatically exported from code.google.com/p/stasiscl
0 stars 0 forks source link

Algalon handling is incorrect, patch attached #148

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
r260 introduced Algalon support, but it's incorrect.  Two main problems:

1) The timeout is too low so it gets confused by his long first pull intro
(lore) and ending, and it doesn't detect victory (he ends friendly like
some of the keepers).  The attached patch does work for our Algalon kills
(with an exception, more on that in part 2).  As an example, here's the
output of stasiscl with the attached patch for our recent two attempt kill
of Algalon 10 man:

http://www.variadic.org/faal/sws/sws-overall-1246158250

And here's the raw combat log for that run:

http://www.variadic.org/faal/WoWCombatLog-20090627-Faal.txt.gz

If you run r260 on it instead, it will generate two false attempts and none
of the attempts will be marked as a victory.

2) The long delay between Algalon going unattackable and going friendly on
a victory can lead to stasiscl not seeing a damage event with the friendly
destFlags settings, although the friendly destFlags do exist in the form of
auras being removed.  I'll open a separate bug for this with more details.

Original issue reported on code.google.com by swbro...@gmail.com on 28 Jun 2009 at 6:25

Attachments: