Open wojake opened 1 year ago
Reduce the potential number of XPOP signature checks performed by counting invalid sigs instead of valid sigs.
https://github.com/Xahau/xahaud/blob/37d3d7dae7c5c404b3635d434b1ee2be0d27695e/src/ripple/app/tx/impl/Import.cpp#L675
Should be changed to 0.2 and named quorumToBail
0.2
quorumToBail
https://github.com/Xahau/xahaud/blob/37d3d7dae7c5c404b3635d434b1ee2be0d27695e/src/ripple/app/tx/impl/Import.cpp#L769-L779
if (invalid sig) -> invalidValidationCount++ In every sig check loop, before we verify the sig: if (invalidValidationCount >= quorumToBail) -> error
We could also keep validationCount but it'd be redundant as invalidValidationCount exist.
validationCount
invalidValidationCount
not mvp but interesting thought (for later)
Reduce the potential number of XPOP signature checks performed by counting invalid sigs instead of valid sigs.
https://github.com/Xahau/xahaud/blob/37d3d7dae7c5c404b3635d434b1ee2be0d27695e/src/ripple/app/tx/impl/Import.cpp#L675
Should be changed to
0.2
and namedquorumToBail
https://github.com/Xahau/xahaud/blob/37d3d7dae7c5c404b3635d434b1ee2be0d27695e/src/ripple/app/tx/impl/Import.cpp#L769-L779
We could also keep
validationCount
but it'd be redundant asinvalidValidationCount
exist.