search

Xahau / xahaud

Codebase for Xahaud - The consensus, RPC & blockchain app for the Xahau network.
https://xahau.network
ISC License
23 stars 11 forks source link

Emitted TXs: add NetworkID too #259

Open WietseWind opened 8 months ago

WietseWind commented 8 months ago

If you look at an emitted TX: random example: https://xahauexplorer.com/explorer/6D7A29E3021A3B2425ADC5AF5221D94E7D704DCBD59535D9EEE86A646D3D6D43

... it doesn't contain NetworkID. It obviously doesn't have to but if tools are relying on transactions to have NetworkID to decide how to deal with them when parsing, it would be useful to include it in emitted TXs too.

Workaroudn for now is to decide the CTID and get the NetworkID from there.

image

Alternatively!!

... Serialised tx lacks network ID field: maybe just rely on CTID anyway and decide to ignore this issue :)

shortthefomo commented 8 months ago

WIP https://github.com/lathanbritz/xahaud/tree/issue/259

RichardAH commented 3 months ago

WIP https://github.com/lathanbritz/xahaud/tree/issue/259

Interesting approach but I think it would be better to inject it directly into the actual serialized txn, otherwise you end up with serder issues (the serialized version differs from the deserialized version)