WietseWind commented 6 months ago

With different amendments not only come different TX types and fields, but also different flags. As we see right now, even the same flag numbers with different meanings. For example, AccountSet flag 16 on XRPL mainnet is asfAllowTrustLineClawback while on Xahau asfDisallowIncomingRemit.

I propose the flags are included in the RPC server_definitions calls, so explorers & clients like Xaman can adapt ther screens (e.g. Sign Request & TX Details information) to a specific network.

I propose an object added to the definitions with an array with e.g. Flags per TX Type, or even an object with TX Type » Flag » integer. (Or any other format).

[
  { transactor: 'AccountSet', flagName: 'asfAllowTrustLineClawback', flag: 16 }
]

or

{
  AccountSet: {
    asfAllowTrustLineClawback: 16
  }
}

Prio

This is needed for:

https://github.com/XRPL-Labs/Xaman-Issue-Tracker/issues/492

RichardAH commented 6 months ago

yep good catch, we'll add to server definitions

zgrguric commented 6 months ago

I would like to see flags included on XRPL also.

WietseWind commented 6 months ago

I would like to see flags included on XRPL also.

Yep we should definitely PR this into xrplf/rippled

WietseWind commented 5 months ago

@N3TC4T This will be in the upcoming xahaud release :) So we can include the right flag names in 3.0 :)

RichardAH commented 5 months ago

https://github.com/Xahau/xahaud/pull/304 https://github.com/Xahau/xahaud/pull/306

Xahau / xahaud

Include Flags in Server Definitions #303

Prio