search

Xahkarias / Evolved-Organs

Repo for the Rimworld mod, EvolvedOrgans (DISCONTINUED: check description for revamp)
2 stars 3 forks source link

Create EVO_E_LeeaniTest_Jeth.xml #1

Closed jetharius closed 5 years ago

jetharius commented 5 years ago

Heres the first file, please make any formatting changes and the like before I start moving on.

Xahkarias commented 5 years ago

Looks good so far, I can see that you are utilizing the "ModCheck.isModLoaded" method from ModCheck. Just to confirm, this means that integrating the ModCheck dll would be required correct? (Don't have a problem with that, just confirming my knowledge)

jetharius commented 5 years ago

I dont think so, I was of the impression that modcheck was a 1.0 integration to do a simple bool test for if a mod is loaded to avoid doing longer checks for if a mod exists or not. (it loaded just fine into your current mod without the modcheck.dll and pushed the bodypart items into the leeani race without throwing any errors)

How do you want me to integrate the rest of the race mods, drop them into the same file or into singular ones?

Xahkarias commented 5 years ago

Oh interesting, I didn't realize it was a vanilla integration. I'm thinking of integrating ModCheck anyway to add those nice boolean xpath functions.

As for the patches, I am leaning to having seperate files. While as you said it would be easier to have a single file and use a replace feature for an ide, I think it would just be neater to have several patches, plus a bunch of ides (well at least VS code and iirc notepad++) have a replace all in a set of files. Your thoughts?

jetharius commented 5 years ago

True but remember to include a solution file for it for clones so that other users can do pulls. I also have a handful of integrations I would like to help add assuming you agree. One of the foremost is questionable ethics, replacing the bench with vatgrown parts. Do you have a discord, or just accept my request on steam and we can directly chat.

On Tue, May 21, 2019 at 12:09 AM Law notifications@github.com wrote:

Oh interesting, I didn't realize it was a vanilla integration. I'm thinking of integrating ModCheck anyway to add those nice boolean xpath functions.

As for the patches, I am leaning to having seperate files. While as you said it would be easier to have a single file and use a replace feature for an ide, I think it would just be neater to have several patches, plus a bunch of ides (well at least VS code and iirc notepad++) have a replace all in a set of files. Your thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Xahkarias/Evolved-Organs/pull/1?email_source=notifications&email_token=AJNNUROGBNHKCMUD5ABZGKTPWOG2NA5CNFSM4HOGOKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV23JJI#issuecomment-494253221, or mute the thread https://github.com/notifications/unsubscribe-auth/AJNNURJOWBZO5SJTVJWH7SDPWOG2NANCNFSM4HOGOKPA .

jetharius commented 5 years ago

As soon as you accept the pull, ill start duplicating for all the other race files for the body parts. I havent looked at the meat parts, I honestly feel that could be better relocated to a protein mash like questionable ethics. It would also be much easier to integrate by just including more recipes for the XXXmeat to protein mash. I'd like to discuss further, accept my steam request or discord me at Jeth#7130

Xahkarias commented 5 years ago

Ah so for questionable ethics, you are proposing merging the organ growing process with their's? Seems interesting. And by meat parts, you are referring to the evolved meat created by butchering human meat correct? I am planning on removing the restriction on human meat to include any humanoid race installed as well.