Xalcon / EnergyConverters

Simple mod which provides a few blocks which can convert energy from and to EU or RF
MIT License
12 stars 17 forks source link

Add configuration options/GUI and cleanup project configuration #12

Closed Tommsy64 closed 7 years ago

Tommsy64 commented 7 years ago

This is a relatively large pull-request. This will close issue #3.

If this gets merged I can port to MC 1.11.2.

Shadows-of-Fire commented 7 years ago

wat

TehNut commented 7 years ago

See, that's not how PRs work. You don't just reformat the codebase and add a new library. And you especially don't change the license.

The only commit that should be here is 323fe3ec42b1f95572d8af3186673c622069d7ec and even that is overloaded with crap that shouldn't be there.

Xalcon commented 7 years ago

First of all, thank you for putting time into this project - but: I'm fine with all of the changes - except point 1 and 3:

  1. The license was set to ARR - All Rights Reserved because I didnt decide on which license I want to go with. Forcing a License via a PR that also adds one of the most needed features is an absolute no-go. You dont make a PR to change the License. Thats not how it works.
  2. I know that the recommended identation style for Java is K&R - but I'm not a java programmer. I dont like that indentation style (And yes, this is my subjective opinion, you are allowed to disagree). If we use any auto-formatter for my projects, it will be one that is configured to do Allman style.

All in all, i wont accept the PR in this state. Most of the suggestes changes in this PR should've been done in their own PR, just to make them easier to understand... and changing the License should've been done via an Issue.

/closed