search

Xalgorithms / general-examples

A repository used for rule package examples. May eventually contain core rules.
Apache License 2.0
1 stars 2 forks source link

.list_id versus .list_name #14

Closed jpotvin closed 4 years ago

jpotvin commented 5 years ago

Looking at:

WHEN envelope:parties.supplier.industry.list_id == 'ISIC'; WHEN envelope:parties.supplier.industry.value == 'G4711'; WHEN item:classification.list_name == 'UNSPSC'; WHEN item:classification.value == '506505';

Shoulldn't .list_id and .list_name both be either one or the other? Probably .list_name is best since _id tends to refer to a more structured _id system and these are just acronyms.

karfai commented 5 years ago

Yes. This is a correct assessment. I'll look into why they are represented this way and make changes where warranted.

karfai commented 4 years ago

The compute platform as it is currently implemented has changed. This is no longer relevant.