Positive or negative value in the reductions_by_distance table?

Xalgorithms / general-examples

A repository used for rule package examples. May eventually contain core rules.

Apache License 2.0

1 stars 2 forks source link

Positive or negative value in the reductions_by_distance table? #2

Closed jpotvin closed 6 years ago

jpotvin commented 6 years ago

Should the $ values in this table be postive or negative? https://github.com/Xalgorithms/general-examples/blob/master/qc-gas-tax/reductions_by_distance.json

Should the rule's formula add or subtract?

karfai commented 6 years ago

They should be positive. The final revision of the document adds a UBL allowance to the document where charge='false', indicating a discount. The original price of the item is not modified, but the final totals (which are generated values) would be updated in Lichen.