search

XaminProject / handlebars.php

Handlebars processor for php
331 stars 134 forks source link

@root special variable like in handlebars-v2.0.0.js #112

Closed majortom731 closed 9 years ago

majortom731 commented 9 years ago

Hi,

I've built support for the @root special variable which allows to access to topmost context from anywhere within a template.

Please review and tell me what you think about it.

Regards

T.

JustBlackBird commented 9 years ago

As for me everything is fine. What do you think @fzerorubigd ?

fzerorubigd commented 9 years ago

Thank you. but please sqush commits into one. @JustBlackBird I think its ok, could you please review this?

fzerorubigd commented 9 years ago

@JustBlackBird Sorry :) I just see your comment :) thank you.

majortom731 commented 9 years ago

Ok, seems I managed to squashed the 2 commits into one, but now Scrutinizer throws an error. ?

fzerorubigd commented 9 years ago

@majortom731 But there is 4 commit now. use git rebase or git rebase --interactve then push result with git push -f in your repo.

majortom731 commented 9 years ago

Working now?

fzerorubigd commented 9 years ago

@majortom731 Thank you!