search

XaminProject / handlebars.php

Handlebars processor for php
331 stars 134 forks source link

Fix handling of named arguments in partials #127

Closed thormeier closed 9 years ago

thormeier commented 9 years ago

Also fix tests that weren't even executed.

Now constructs like {{> partial foo=bar.baz }} are also possible.

thormeier commented 9 years ago

Fixed :)

JustBlackBird commented 9 years ago

Thank you @thormeier !

thormeier commented 9 years ago

You're very welcome!

mfeltscher commented 8 years ago

Since I'm using partials with named arguments quite a lot it would be nice if you could release a new version (like 0.10.2) of the library. Would that be possible? :)

JustBlackBird commented 8 years ago

@mfeltscher, we definitely will release the new version but I'm not sure it will be done soon. At the meantime you can specify dev-master for composer's dependency instead of exact version.

mfeltscher commented 8 years ago

@JustBlackBird Due to minimum stability levels in our applications this is not possible. As for now I'm using a @thormeier's latest commit as my version but want to get rid of this as soon as possible.

fzerorubigd commented 8 years ago

@JustBlackBird I think its good idea to release the 0.10.2 for now. I don't see 0.11 in the next few month :)

JustBlackBird commented 8 years ago

@mfeltscher, @fzerorubigd done!

fzerorubigd commented 8 years ago

@JustBlackBird Thanks :)

mfeltscher commented 8 years ago

Thanks! :) cc: @thormeier