search

XaminProject / handlebars.php

Handlebars processor for php
331 stars 132 forks source link

Please remove "var_export"! #129

Closed Zemistr closed 9 years ago

Zemistr commented 9 years ago

Hi, pleeeeeeeease remove "var_export" from \Handlebars\Context::_findVariableInContext !

When I use bigger data, whole server is down...

fzerorubigd commented 9 years ago

@Zemistr thank you for your report. @JustBlackBird I think the only one is https://github.com/XaminProject/handlebars.php/blob/master/src/Handlebars/Context.php#L291and there is no need to keep it.

JustBlackBird commented 9 years ago

@Zemistr thanks for the report, but please, don't use such titles anymore!

@fzerorubigd you're right! var_export is not needed there. Variable name should be added to the exception instead of the context. I've done so in #130, could you review it?

fzerorubigd commented 9 years ago

@JustBlackBird Thank you, It's done.

Zemistr commented 9 years ago

@JustBlackBird: YW and sorry :sweat_smile:

Many, many thanks! :kissing: