search

XaminProject / handlebars.php

Handlebars processor for php
331 stars 134 forks source link

PHP 7.3 error #174

Open gabrielkoerich opened 5 years ago

gabrielkoerich commented 5 years ago

I got this when testing on PHP 7.3:

ErrorException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php:167
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:569
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:711
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:635
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:210

Should it be changed to break or continue 2?

ivantcholakov commented 5 years ago

I hit these: vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php: 167 vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php: 213