search

XaminProject / handlebars.php

Handlebars processor for php
331 stars 134 forks source link

Subexpressions #56

Closed majortom731 closed 10 years ago

majortom731 commented 10 years ago

Handled them in Template::_handlebarsStyleSection()

Probably not the best place to do this...

everplays commented 10 years ago

From what I can see, (baz) in something like {{foo bar '(baz)'}} will be executed as an expression, right? I think it'd be better if we do something about this.

Could you please fix the coding style issues? They're visible in travis. Also #55 and this one share code/commit. If you're not going to remove them from this one, please close #55.

majortom731 commented 10 years ago

How do I get the CI system to do a rebuild?

everplays commented 10 years ago

@majortom731 not sure what's wrong. could be because this PR can't be merged in fast forward manner. BTW, you can run the tests locally with this command: ./vendor/bin/phpunit && ./vendor/bin/phpcs -n src/ (of course after running composer install).