search

Xamla / torch-ros

Torch7/lua wrapper of roscpp via ffi.
http://www.xamla.com/
BSD 3-Clause "New" or "Revised" License
20 stars 5 forks source link

Fixed getCount in test #1

Closed ghost closed 8 years ago

ghost commented 8 years ago

count is not indexed as a lua function, and calling it will result in errors. This can be fixed by referencing :getCount(). This change is made in the test files in the package.

andreaskoepf commented 8 years ago

@MichaelGhaben thanks a lot for testing this early version of torch-ros and reporting the bug. I will make some minor changes to simplify sending and receiving messages during the next days.

ghost commented 8 years ago

No worries. I was trying to use this for a project of mine and this is quite helpful. If you put up a todo list, I might do things from it if I get the time.

andreaskoepf commented 8 years ago

@MichaelGhaben actually the simplified message reception code (without explicit message deserialization and access to the internal message buffer) was already implemented :-)... see https://github.com/Xamla/torch-ros/commit/c4e565646f20b97cb33dfd7a85f878ee53b2c467 . During the next days I will run some tests with large binary messages (images etc). Support for service-advertising and actionlib will come during the next few days...