search

XanaduAI / MrMustard

A differentiable bridge between phase space and Fock space
https://mrmustard.readthedocs.io/
Apache License 2.0
78 stars 27 forks source link

Adding/fixing gates in lab_dev transformations #398

Closed kaspernielsen96 closed 6 months ago

kaspernielsen96 commented 6 months ago

Context: Fixing mistakes of the Rgate and adding Identity to lab_dev

Description of the Change: Correcting the Abc triplet of the Rgate from squeezing Abc to rotation Abc and updating the tests. Adding the identity transformation and tests of it.

Benefits: More (and correct) gates in lab_dev.

Possible Drawbacks:

Related GitHub Issues:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.65%. Comparing base (c987bd0) to head (a28a420).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #398 +/- ## =========================================== + Coverage 87.43% 87.65% +0.22% =========================================== Files 81 81 Lines 6135 6142 +7 =========================================== + Hits 5364 5384 +20 + Misses 771 758 -13 ``` | [Files](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) | Coverage Δ | | |---|---|---| | [...mustard/lab\_dev/transformations/transformations.py](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398?src=pr&el=tree&filepath=mrmustard%2Flab_dev%2Ftransformations%2Ftransformations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI#diff-bXJtdXN0YXJkL2xhYl9kZXYvdHJhbnNmb3JtYXRpb25zL3RyYW5zZm9ybWF0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Last update [c987bd0...a28a420](https://app.codecov.io/gh/XanaduAI/MrMustard/pull/398?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI).
kaspernielsen96 commented 6 months ago

The Tensorflow test worked for the initial push. The difference to the second is I ran the 'black formatting' and now Tensorflow fails.