Closed mstechly closed 6 years ago
Thanks for the PR @mstechly :) @mariaschuld @josh146 any comments?
Looks great @mstechly! I've added some small comments (all minor), and wait for @mariaschuld to have a look.
@mariaschuld I think that consistency between numerical and tf is important for the beginner - it was a little bit confusing to me when I wanted to try the other backend. Maybe we could add a commented section, which shows the alternative way? I know that leaving commented code everywhere is not the best practice, but these are examples and not production code, so I think it will be more instructive. WDYT?
Ok, you convinced me! :) Let's not leave comments, but after the pull I will mention the old version in the doc tutorials.
Happy to merge from my side, conditioned on Joshes final comments. Think he is traveling at the moment...
Just had a look. Perhaps the best approach is to use the same parameters list syntax in the basic tutorials, but have a extra section in the TF tutorial providing the alternative naming approach? Aside from that, looks good to merge from me.
Codecov Report
Continue to review full report at Codecov.