search

XanaduAI / quantum-neural-networks

This repository contains the source code used to produce the results presented in the paper "Continuous-variable quantum neural networks". Due to subsequent interface upgrades, these scripts will work only with Strawberry Fields version <= 0.10.0.
https://arxiv.org/abs/1806.06871
Apache License 2.0
297 stars 86 forks source link

new example: tetrominos_learning #2

Closed andreamari closed 5 years ago

trbromley commented 5 years ago

Thanks @andreamari

co9olguy commented 5 years ago

@andreamari you're been working with the code lately. Can you confirm that the scripts in this PR generate the tetromino images after training?

andreamari commented 5 years ago

@co9olguy I am sure it worked before all changes after the PR. Shall I make a new test?

co9olguy commented 5 years ago

yep, just in case something inadvertently changed during PR, good to rerun a test

andreamari commented 5 years ago

Ok I am running a test on workhorse. I'll let you know, probably tomorrow, the results.

andreamari commented 5 years ago

It was good to make a test. Indeed there was a problem in the definition of the LOTISJZ matrices! After fixing the problem I confirm that all tetrominos are generated correctly. Actually 10k-15k iterations are sufficient to show nice figures. At the moment the default value for the nnumber of repetitions is 50k, if you think it is useful we can decrease it. Otherwise I think the code is ok.

trbromley commented 5 years ago

At the moment the default value for the nnumber of repetitions is 50k, if you think it is useful we can decrease it. Otherwise I think the code is ok.

@andreamari: Sure, how about 20k?

co9olguy commented 5 years ago

All set to merge this one @andreamari @trbromley ?

If so, can you also update the README.md file in the main repo to add this example?

trbromley commented 5 years ago

Good to merge from my side. @andreamari let me know if you need a hand with the README.md changes. Thanks!

andreamari commented 5 years ago

Ok to merge also form my side. I just updated the README.md file. You can check if you like the description of the new example.

co9olguy commented 5 years ago

Great thanks @andreamari @trbromley !