search

XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
754 stars 191 forks source link

Rename StarshipEngine to RemoteEngine, starship CLI to sf #316

Closed josh146 closed 4 years ago

josh146 commented 4 years ago

This is the last change to be merged into the demo branch, before demo is merged into master.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (demo@cce71d1). Click here to learn what that means. The diff coverage is 100%.

@@           Coverage Diff           @@
##             demo     #316   +/-   ##
=======================================
  Coverage        ?   97.66%           
=======================================
  Files           ?       50           
  Lines           ?     6251           
  Branches        ?        0           
=======================================
  Hits            ?     6105           
  Misses          ?      146           
  Partials        ?        0
Impacted Files Coverage Δ
strawberryfields/configuration.py 100% <ø> (ø)
strawberryfields/api/connection.py 97.64% <ø> (ø)
strawberryfields/api/job.py 93.02% <ø> (ø)
strawberryfields/engine.py 94.55% <100%> (ø)
strawberryfields/cli/__init__.py 90.41% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cce71d1...22c6e99. Read the comment docs.

antalszava commented 4 years ago

One comment before merge: updating the CHANGELOG. :) As starship appeared in there a couple of times, it would explain earlier PR entries in there to the users.

josh146 commented 4 years ago

One comment before merge: updating the CHANGELOG. :) As starship appeared in there a couple of times, it would explain earlier PR entries in there to the users.

Good catch. I'm thinking it makes sense to accumulate those entries into one entry, summarising the new RemoteEngine and related functionality, since this will be a single squash commit into master. We did a similar thing when we released the apps layer

josh146 commented 4 years ago

Note: tests are failing due to an API change in the new release of pytest. I'm going to temporarily pin travis to the previous pytest version, and then the test suite can be upgraded in a subsequent PR (as it will be quite a lot of changes)