Closed josh146 closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
master@e557ba2
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage ? 97.66%
=========================================
Files ? 50
Lines ? 6252
Branches ? 0
=========================================
Hits ? 6106
Misses ? 146
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/cli/__init__.py | 90.41% <ø> (ø) |
|
strawberryfields/configuration.py | 100% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e557ba2...e46ad7f. Read the comment docs.
Context:
In #319, the changes were requested for the pages
configuration.rst
,sf_configuration.rst
, andsf_cli.rst
. These are described below.Description of the Change:
[x] Swap to using command prompt for examples
[x] Replace
cat
withtype
for the command prompt segments[x] Standardize the dummy authentication token to
AUTHENTICATION_TOKEN
, and note everywhere it appears that the user should replace it with their own token[x] Refactor the introduction configuration to instead make it focused on the cloud platform. Note: while focusing on the cloud platform, I changed the title to be 'Photonic hardware', so it displays well in the TOC in the sidebar.
[x] Always put python store account first
[x] Remove the references to the :func:
~.configuration_wizard
page.[x] In doc/introduction/configuration.rst link to the hardware tutorial
[x] Specify that the
INFILE
argument for the CLI is a blackbird script[x] Place the corresponding environment variable sentences on newlines
Benefits: suggested changes are incorporated
Possible Drawbacks: Changes requested for the hardware tutorial will be made in a new PR, once this has been merged in.
Related GitHub Issues: #319