search

XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
754 stars 191 forks source link

Fix a json-issue in the cancel_job method of sf.api.connection.Connection #336

Closed lneuhaus closed 4 years ago

lneuhaus commented 4 years ago

Context: Remote engine job cancellation.

Description of the Change: Fixed a bug that prevented jobs from being cancelled when cancelling a running job.

Benefits: Jobs can be cancelled now.

Possible Drawbacks: None.

Related GitHub Issues: None.

codecov[bot] commented 4 years ago

Codecov Report

Merging #336 into master will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files          51       51              
  Lines        6346     6345       -1     
==========================================
- Hits         6200     6199       -1     
  Misses        146      146
Impacted Files Coverage Δ
strawberryfields/api/connection.py 97.64% <ø> (-0.03%) :arrow_down:
strawberryfields/circuitspecs/X12.py 100.00% <100.00%> (ø)
strawberryfields/circuitspecs/X8.py 100.00% <100.00%> (ø)
strawberryfields/circuitspecs/__init__.py 100.00% <100.00%> (ø)
strawberryfields/engine.py 94.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 605819a...76f083c. Read the comment docs.