XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
754 stars 191 forks source link

Increasing required version for The Walrus #380

Closed antalszava closed 4 years ago

antalszava commented 4 years ago

Increasing the required version for The Walrus such that the newest features are available.

codecov[bot] commented 4 years ago

Codecov Report

Merging #380 into master will decrease coverage by 9.98%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   97.76%   87.77%   -9.99%     
==========================================
  Files          52       52              
  Lines        6387     6387              
==========================================
- Hits         6244     5606     -638     
- Misses        143      781     +638     
Impacted Files Coverage Δ
strawberryfields/backends/fockbackend/circuit.py 14.77% <0.00%> (-83.65%) :arrow_down:
strawberryfields/backends/fockbackend/backend.py 33.08% <0.00%> (-66.92%) :arrow_down:
strawberryfields/backends/fockbackend/ops.py 30.85% <0.00%> (-61.15%) :arrow_down:
strawberryfields/backends/states.py 59.79% <0.00%> (-37.19%) :arrow_down:
strawberryfields/utils.py 86.00% <0.00%> (-13.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30c2364...dc480a0. Read the comment docs.

antalszava commented 4 years ago

@josh146 thanks for getting that! How come we are pinning in setup.py?

josh146 commented 4 years ago

@josh146 thanks for getting that! How come we are pinning in setup.py?

While not essential, this is mostly for users upgrading Strawberry Fields versions; it ensures that The Walrus is also upgraded.