XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
754 stars 191 forks source link

Test a possible bug in the backend. #497

Closed nquesada closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #497 (0b9eb6c) into master (75e3c26) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          70       70           
  Lines        7313     7313           
=======================================
  Hits         7156     7156           
  Misses        157      157           
Impacted Files Coverage Δ
...fields/backends/gaussianbackend/gaussiancircuit.py 98.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75e3c26...0b9eb6c. Read the comment docs.

josh146 commented 3 years ago

@nquesada what bug does this fix? It would be good to include a test for it, just for (a) verification it fixes it, and (b) making sure we catch this bug in the future.

Also don't forget to update the changelog!

co9olguy commented 3 years ago

How come this bug needed to be tested via PR? :thinking:

nquesada commented 3 years ago

@co9olguy so that all the tests are run? I wanted to know if the little, but very significant, change I made would break any test.

co9olguy commented 3 years ago

How come you didn't want to run the tests locally?