Closed felipeoyarce closed 3 years ago
Hey @thisac feel free to test these properties combining more operations, they should work properly :hugs:
Merging #570 (0eefe17) into master (bcffdee) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 75 75
Lines 8399 8411 +12
=======================================
+ Hits 8263 8275 +12
Misses 136 136
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/program.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bcffdee...0eefe17. Read the comment docs.
Thanks @felipeoyarce. It seems like a lot of the tests have changed slightly (perhaps due to running black on the tests files). It would be good to refrain from changing these here and only focus on the functionality you've added.
Otherwise it looks good, apart from a few changes in some docstrings, e.g. code being represented by double backticks (
`) instead of single (
) ones due to us using Sphinx for the docs.
Thanks @thisac!
Hi @felipeoyarce, thanks for this PR! We have a SF feature freeze at the moment, but will be able to merge this PR in early next week :)
Sure! Thanks @josh146 and @thisac :hugs:
Thanks for the contrib @felipeoyarce! Don't forget to update the changelog with your name and contribution :slightly_smiling_face:
Thanks for the contrib @felipeoyarce! Don't forget to update the changelog with your name and contribution
Oh, thanks @co9olguy :smile:
@felipeoyarce @thisac Another reminder to add this contribution to the changelog and take credit for your nice contribution :slightly_smiling_face:
Context: As the related issue #302 states
Description of the Change:
New properties added to
Program
that return True/False for when feed-forwarding and/or post-selection is used. These properties arepost-selection
andfeed-forward
.Benefits:
Improves the developer experience because now you can just you use these new properties instead of having to check each operation in the circuit each time you want to run it.
Sample old code for checking this using try-except:
Possible Drawbacks: None
Related GitHub Issues: Issue #302