search

XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
747 stars 186 forks source link

Remove measurements and preparations from Gaussian and GaussianMerge #594

Closed nquesada closed 3 years ago

nquesada commented 3 years ago

The compilers Gaussian and GaussianMerge should not accept as primitives measurement and at least some class of preparations. This PR removes this objects from the list things these compilers accept.

Addresses https://github.com/XanaduAI/strawberryfields/issues/593

codecov[bot] commented 3 years ago

Codecov Report

Merging #594 (0c538f8) into master (6b7b5c5) will decrease coverage by 35.52%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #594       +/-   ##
===========================================
- Coverage   98.44%   62.92%   -35.53%     
===========================================
  Files          76       76               
  Lines        8752     8752               
===========================================
- Hits         8616     5507     -3109     
- Misses        136     3245     +3109
Impacted Files Coverage Δ
strawberryfields/compilers/gaussian.py 100.00% <ø> (ø)
strawberryfields/compilers/gaussian_merge.py 18.88% <ø> (-81.12%) :arrow_down:
strawberryfields/apps/subgraph.py 10.11% <0.00%> (-89.89%) :arrow_down:
strawberryfields/apps/clique.py 10.67% <0.00%> (-89.33%) :arrow_down:
strawberryfields/io.py 8.90% <0.00%> (-87.96%) :arrow_down:
strawberryfields/apps/qchem/dynamics.py 12.65% <0.00%> (-87.35%) :arrow_down:
strawberryfields/decompositions.py 13.89% <0.00%> (-85.88%) :arrow_down:
strawberryfields/plot.py 13.15% <0.00%> (-85.09%) :arrow_down:
strawberryfields/apps/qchem/utils.py 15.78% <0.00%> (-84.22%) :arrow_down:
strawberryfields/apps/similarity.py 16.02% <0.00%> (-83.98%) :arrow_down:
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b7b5c5...0c538f8. Read the comment docs.

nquesada commented 3 years ago

OK. seems like removing measurement is after all not a good idea. For the moment it is fine to leave them there, but eventually it might be useful to think more carefully about this.