Closed lneuhaus closed 3 years ago
Merging #616 (5ca2e37) into master (cda84e4) will decrease coverage by
0.19%
. The diff coverage is40.00%
.
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
- Coverage 98.55% 98.35% -0.20%
==========================================
Files 77 77
Lines 8857 8880 +23
==========================================
+ Hits 8729 8734 +5
- Misses 128 146 +18
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/api/connection.py | 87.75% <37.93%> (-12.25%) |
:arrow_down: |
strawberryfields/api/devicespec.py | 95.23% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cda84e4...5ca2e37. Read the comment docs.
ch7988
closing since this won't be implemented
Before submitting
Please complete the following checklist when submitting a PR:
[ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory!
[ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[ ] Ensure that the test suite passes, by running
make test
.[ ] Ensure that code is properly formatted, by running
make format
orblack -l 100 strawberryfields
. You will need to have the Black code format installed:pip install black
.[ ] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[ ] The Strawberry Fields source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply
pip install pylint
, and then runpylint strawberryfields/path/to/file.py
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: