Closed sduquemesa closed 2 years ago
Merging #628 (9ff4d38) into master (f7b9e70) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 77 77
Lines 8987 8989 +2
=======================================
+ Hits 8857 8859 +2
Misses 130 130
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/apps/similarity.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f7b9e70...9ff4d38. Read the comment docs.
Context: Factorials of numbers larger than 170 do not fit into an
int
, hence return float when neededDescription of the Change: use the
qarg exact=True/False
onscipy.special.factorial
when the result cannot be fitted inside anint
Benefits: Error won't be raised when
factorial
is called with a large numberPossible Drawbacks: None
Related GitHub Issues: #284