Closed thisac closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
integrate-xanadu-cloud-client@188123b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## integrate-xanadu-cloud-client #644 +/- ##
================================================================
Coverage ? 98.22%
================================================================
Files ? 75
Lines ? 8978
Branches ? 0
================================================================
Hits ? 8819
Misses ? 159
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 188123b...10fb39a. Read the comment docs.
Context: As part of the migration to the XCC API, the
DeviceSpec
class needs to be updated.Description of the Change:
DeviceSpec
class, so that it only contains the specification with which is was initialized. If the spec needs to be refreshed a newDeviceSpec
object needs to be created.target
is now retrieved from the device specification rather than passed separately to the__init__()
method. This avoids any ambiguities.Benefits:
DeviceSpec
class works with XCC.DeviceSpec
class only encapsulates the device specification (providing some helper methods), and does not handle any connections.Possible Drawbacks:
Related GitHub Issues: None