XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
745 stars 187 forks source link

Use refactored gaussian gate from The Walrus #646

Closed sduquemesa closed 2 years ago

sduquemesa commented 2 years ago

Context: PR #295 on The Walrus deprecates the C++ implementation of gaussian_gate and grad_gaussian_gate in favor of the numba implementation. This in turn modifies the signatures of the imported functions.

Description of the Change: This PR will use the new implementation of gaussian_gate and grad_gaussian_gate on The Walrus

Benefits: The Walrus has less C++ dependencies

Possible Drawbacks: None

Related GitHub Issues: None

sduquemesa commented 2 years ago

Note: checks will fail until a new version of the walrus including the mentioned changes (PR #295 on The Walrus) is released.

josh146 commented 2 years ago

Note: checks will fail until a new version of the walrus including the mentioned changes (PR #295 on The Walrus) is released.

@sduquemesa you can temporarily update requirements.txt in this branch to point to the correct wheel here: http://xanadu-wheels.s3-website-us-east-1.amazonaws.com/

In this case you probably want

http://xanadu-wheels.s3-website-us-east-1.amazonaws.com/thewalrus-0.17.0.dev0+20211101181237-cp38-cp38-manylinux2010_x86_64.whl

since the CI uses Python 3.8

codecov[bot] commented 2 years ago

Codecov Report

Merging #646 (6f4173a) into master (5820d40) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          77       77           
  Lines        9178     9178           
=======================================
  Hits         9020     9020           
  Misses        158      158           
Impacted Files Coverage Δ
strawberryfields/backends/tfbackend/ops.py 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5820d40...6f4173a. Read the comment docs.