Closed thisac closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
integrate-xanadu-cloud-client@53b95f7
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## integrate-xanadu-cloud-client #650 +/- ##
================================================================
Coverage ? 98.29%
================================================================
Files ? 74
Lines ? 8934
Branches ? 0
================================================================
Hits ? 8782
Misses ? 152
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 53b95f7...f9b01bc. Read the comment docs.
Context: As part of the XCC integration, there's a new
xcc.Job
class that will replace the oldstrawberryfields.api.Job
class.Description of the Change:
strawberryfields/api/job.py
is removed and all uses ofstrawberryfields.api.Job
is replaced withxcc.Job
.xcc.Job
object is returned when runningRemoteEngine.run_async()
.xcc.Job
object when runningRemoteEngine.run_async()
.tests/api/test_remote_engine
tests are updated andtests/api/test_job.py
is removed.Benefits: The
strawberryfields.api.Job
class is removed in favour ofxcc.Job
and we're one step closer to XCC integration.Possible Drawbacks:
RemoteEngine.run_async()
the returnedxcc.Job
object doesn't return results as aResult
object (as before, and asRemoteEngine.run()
still does). The user will need to pass thejob.result
results manually into aResult
object.Related GitHub Issues: None