Closed thisac closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
integrate-xanadu-cloud-client@188123b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## integrate-xanadu-cloud-client #651 +/- ##
================================================================
Coverage ? 98.20%
================================================================
Files ? 75
Lines ? 8982
Branches ? 0
================================================================
Hits ? 8821
Misses ? 161
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 188123b...7138dc9. Read the comment docs.
Context: As part of the XCC integration, the Result class needs to be updated.
Description of the Change:
Result
class now only takes a result dictionary containing all samples.samples
property returns the first entry in the result dictionary (which should be the pure samples).all_samples
have been renamed tosamples_dict
.Result._is_stateful
has been removed in favour ofself._state is not None
.Benefits: Things work better together with XCC and the dictionary type samples that will be returned from the HW.
Possible Drawbacks:
samples
property returns the first entry in the result dictionary assuming they are the pure samples).Result._is_stateful
has been removed, and does not seem to have a clear use case.Related GitHub Issues: None