XanaduAI / strawberryfields

Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.
https://strawberryfields.ai
Apache License 2.0
737 stars 187 forks source link

Remove `fill_template` calls in `RemoteEngine.run_async` #655

Closed thisac closed 2 years ago

thisac commented 2 years ago

Context: Some traces of removed methods were left from the DeviceSpec XCC integration update.

Description of the Change: Removes non-existing DeviceSpec.fill_template and DeviceSpec.is_formatted calls in RemoteEngine.run_async

Benefits: It will now work to run TDM programs remotely using the updated DeviceSpec class.

Possible Drawbacks: None

Related GitHub Issues: None

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (integrate-xanadu-cloud-client@fc747a0). Click here to learn what that means. The diff coverage is n/a.

@@                       Coverage Diff                        @@
##             integrate-xanadu-cloud-client     #655   +/-   ##
================================================================
  Coverage                                 ?   98.28%           
================================================================
  Files                                    ?       72           
  Lines                                    ?     8809           
  Branches                                 ?        0           
================================================================
  Hits                                     ?     8658           
  Misses                                   ?      151           
  Partials                                 ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc747a0...879772e. Read the comment docs.