Closed sduquemesa closed 2 years ago
Merging #675 (5228354) into master (2d6e3ea) will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 98.29% 98.33% +0.04%
==========================================
Files 75 75
Lines 9036 9036
==========================================
+ Hits 8882 8886 +4
+ Misses 154 150 -4
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/logger.py | 100.00% <0.00%> (+16.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2d6e3ea...5228354. Read the comment docs.
Context: Tests in
test_logger.py
fail locally when runningpytest
directly.Description of the Change: This PR solves the failing tests by
test_default_sf_logger
,test_custom_logger_before_sf_logger_with_higher_level
.Additional to the above, some unused arguments on test functions were removed.
Benefits: Logger test no longer fail when using
pytest
directly.Possible Drawbacks: None
Related GitHub Issues: None