Closed thisac closed 2 years ago
Merging #679 (f60d9a8) into master (529e97e) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 98.33% 98.34%
=======================================
Files 75 75
Lines 9036 9038 +2
=======================================
+ Hits 8886 8888 +2
Misses 150 150
Impacted Files | Coverage Δ | |
---|---|---|
strawberryfields/program.py | 100.00% <ø> (ø) |
|
strawberryfields/tdm/tdmprogram.py | 98.29% <ø> (ø) |
|
strawberryfields/__init__.py | 95.83% <100.00%> (ø) |
|
strawberryfields/device.py | 96.77% <100.00%> (ø) |
|
strawberryfields/engine.py | 95.88% <100.00%> (-0.04%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 529e97e...f60d9a8. Read the comment docs.
Context: The certificate is needed for the TD3 pipeline. It makes sense adding it to the
DeviceSpec
class (which contains the device specification). This also warrants a name change of the class, calling itDevice
rather thanDeviceSpec
(this also makes sense since we've had a tendency to callDeviceSpec
objects simplydevice
).Note: The plan is to later to remove the
sf.Device
class altogether and only keep thexcc.Device
class. Some further changes need to be made for this to work properly, although this would probably be the better solution in the long run, avoiding using multiple abstractions for the same thing.Description of the Change:
DeviceSpec
class is renamedDevice
.Device
initialization along with the specification.certificate
method is added to theDevice
class, which returns the certificate attribute.Benefits:
Device
class objects.DeviceSpec
object?).Possible Drawbacks:
sf.Device
andxcc.Device
.Related GitHub Issues: None