XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.

https://the-walrus.readthedocs.io

Apache License 2.0

101 stars 55 forks source link

Banded unitaries #208

Closed nquesada closed 3 years ago

nquesada commented 3 years ago

Adds extra functionality for the generation of banded unitary matrices.

codecov[bot] commented 3 years ago

Codecov Report

Merging #208 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1172      1195   +23     
=========================================
+ Hits          1172      1195   +23

Impacted Files	Coverage Δ
thewalrus/random.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7be5b2...62ae1bb. Read the comment docs.

glassnotes commented 3 years ago

Nice! Are you still looking for a way to smooth/fill in the missing chunks?

nquesada commented 3 years ago

hey @glassnotes --- It would definitely be nice if one could remove the dents. I gave some though to it yesterday but was unable to come up with anything good. On the other hand, this still does the job in that it gives a unitary with the specified bandwidth... Maybe it is something to be left for a future PR?

glassnotes commented 3 years ago

hey @glassnotes --- It would definitely be nice if one could remove the dents. I gave some though to it yesterday but was unable to come up with anything good. On the other hand, this still does the job in that it gives a unitary with the specified bandwidth... Maybe it is something to be left for a future PR?

Yeah agreed - this seems like an interesting research problem to explore first!