XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
101 stars 55 forks source link

Fix OSX wheel builds #224

Closed thisac closed 3 years ago

thisac commented 3 years ago

OSX wheel builds are failing. This is an attempt to fix that!

thisac commented 3 years ago

@josh146 The tests now pass (after a bit of tweaking). The only thing is that it's running on Python 3.9, which means that the wheel-uploading might not work on merging with master.

I suspect the following line might cause some errors.

pip3 install --user https://github.com/joerick/libcloud/archive/v1.5.0-s3fix.zip wheelhouse-uploader

I'm not sure exactly why v1.5 is used for libcloud, or if a later version might work as well, although locally, using Python 3.9 under Linux, I can install later versions of both libcloud and wheelhouse-uploader by simply pip install wheelhouse-uploader (in the macOS case, pip3 would need to be used though).

codecov[bot] commented 3 years ago

Codecov Report

Merging #224 (75ed2d2) into master (567be83) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1191      1191           
=========================================
  Hits          1191      1191           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 567be83...75ed2d2. Read the comment docs.

josh146 commented 3 years ago

pip3 install --user https://github.com/joerick/libcloud/archive/v1.5.0-s3fix.zip wheelhouse-uploader

I'm not sure exactly why v1.5 is used for libcloud, or if a later version might work as well, although locally, using Python 3.9 under Linux, I can install later versions of both libcloud and wheelhouse-uploader by simply pip install wheelhouse-uploader (in the macOS case, pip3 would need to be used though).

Ah, there is some background here in the cibuildwheel docs:

https://cibuildwheel.readthedocs.io/en/stable/deliver-to-pypi/#semi-automatic-method-using-wheelhouse-uploader

The reason being that libcloud used to have a bug; however, it might be fixed now?