XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
101 stars 55 forks source link

Pure_state_amplitude prefactor fix #231

Closed rachelchadwick closed 3 years ago

rachelchadwick commented 3 years ago

Context: Bugfix

Description of the Change: Apply complex conjugate to displacement in the prefactor for pure_state_amplitude

Benefits:

Possible Drawbacks:

Related GitHub Issues:

nquesada commented 3 years ago

Thanks for finding this bug!

codecov[bot] commented 3 years ago

Codecov Report

Merging #231 (60a3219) into master (655e089) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1200      1228   +28     
=========================================
+ Hits          1200      1228   +28     
Impacted Files Coverage Δ
thewalrus/quantum/__init__.py 100.00% <ø> (ø)
thewalrus/quantum/fock_tensors.py 100.00% <100.00%> (ø)
thewalrus/quantum/photon_number_distributions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 919d6a9...60a3219. Read the comment docs.